Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update view and config file to support latest @editorjs/list block #7

Merged
merged 3 commits into from
Aug 31, 2024
Merged

Update view and config file to support latest @editorjs/list block #7

merged 3 commits into from
Aug 31, 2024

Conversation

musilondrej
Copy link
Contributor

This pull request is in response to a change in the @editorjs/list block. The latest version of @editorjs/list generates data with a style parameter, as shown below:

{
    "id": "vQMrQPWD-O",
    "type": "list",
    "data": {
        "style": "unordered",
        "items": [
            "Item 1",
            "Item 2"
        ]
    }
}

To align with this new output format, the view and the config file have been updated to support the style parameter for list formatting.

Copy link
Owner

@alaminfirdows alaminfirdows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@musilondrej Thanks for the PR, could you please update the code to make it more readable?

resources/views/blocks/list.blade.php Outdated Show resolved Hide resolved
@alaminfirdows alaminfirdows added the good first issue Good for newcomers label Oct 6, 2023
@emaia
Copy link

emaia commented Aug 24, 2024

@alaminfirdows can you check this one please?

@alaminfirdows alaminfirdows changed the base branch from master to 2.x August 31, 2024 07:04
Copy link
Owner

@alaminfirdows alaminfirdows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaminfirdows alaminfirdows merged commit 1434834 into alaminfirdows:2.x Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants