Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more entities for viomi.v18 #963

Merged
merged 12 commits into from
Jan 18, 2023
Merged

more entities for viomi.v18 #963

merged 12 commits into from
Jan 18, 2023

Conversation

blakadder
Copy link
Contributor

  • added sub entities for viomi.vacuum.v18

  • added translations to English

  • added miot-spec modifications

still incomplete due to #962 and #960

@al-one
Copy link
Owner

al-one commented Dec 29, 2022

@blakadder Please test the last commit of this PR.

@blakadder
Copy link
Contributor Author

blakadder commented Dec 31, 2022

this is as final as it gets with the current code...

i had to redo the property:fault becuase I was getting error codes not listed in miot spec for the device but I found an extended list under viomi.vacuum.v37 and used that instead

renamed siid 4 piid 13 to "Mop State" since it used a property name that was repeating and I couldn't get only that sensor

imageimage

@al-one al-one merged commit 5ad6a39 into al-one:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants