Fix humidifier mode setting when power is off #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the (de)humidifier is turned off, the "State" and "Mode" in the Lovelace card are both showing "Off":
However if I change mode to anything other than "Off" without first turning state to "On", nothing happens and an error can be seen in the log:
I think it makes sense that changing the mode during power off should firstly turn it on then set the mode. I'd love to hear more opinions about this behaviour.
Also this is only tested on NWT 18L Dehumidifier (nwt.derh.wdh318efw1) since that's the only (de)humidifier I have on hand. It may need more testing with more devices.