feat: upgrade to Angular 9 #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use package built from the following PR oferh/ng2-completer#448. This is a temporary fix until issue form original completer fixed. oferh/ng2-completer#448
We no longer have a direct dependency on tslib. Instead it is now listed a peerDependency. This matches Angular framework.
let's add that this is a temporary measure and we have on current plans on supporting the completer library. |
nnixaa
approved these changes
Mar 23, 2020
2 tasks
yggg
pushed a commit
to akveo/ngx-admin
that referenced
this pull request
Mar 30, 2020
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
maksim-karatkevich
pushed a commit
to akveo/ngx-admin
that referenced
this pull request
May 22, 2020
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
elupanov
added a commit
to akveo/ngx-admin
that referenced
this pull request
May 22, 2020
…#5694) * chore: update README for extra theme (#5466) * fix(tinymce): set absolute path for skin url (#5491) * feat: add calendar with week numbers example (#5515) * chore(readme): update bundles section text * fix(forms): add missing forms module import (#5530) * feat: update Nebular to 4.4.0 (#5533) * chore(readme): update bundles image (#5565) * chore: add bundles black friday deal (#5569) * chore(readme): update black friday 2019 image (#5570) * chore(readme): remove bundles discounts image (#5574) * chore(readme): update bundles image (#5575) * feat(seo): add canonical tag (#5578) * chore(analytics): add proper analytics tracking URLs (#5604) * feat: Material theme * feat: upgrade to Angular 9 and Nebular 5 (#5628) BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)). * Upgrade to the latest minor version of Angular * Upgrade to the latest major version of Angular * Upgrade to nebular 5 beta, remove "angular-tree-component" package * Remove packages uncompatible with Ivy * Fix post-upgrade errors * Replace @agm/core with @angular/google-maps * Fix search-map component using @angular/google-maps * Move material theme files from @nebular * Add missing images and change fg text color of dark material theme to bright white * Implement ripple effect for material themes * Add material style overrides * Add ripple effects to controls across application * Configure material theme, add material button and input examples * Add toggle button example * Fix lint warnings * Add material menu icon for material themes * Fix lint warnings for styles * Set menu font-weight to normal for material themes * Add "hover" and "active" styles for material menu * Update material styles * Override input styles for material themes * Override select styles for material themes * Hide rounded inputs for material themes * Update material styles * Remove non-material themes * Revert "Remove non-material themes" This reverts commit c2e3194. * Fix actions color * Fix lint warnings * Fix scrollbar for "traffic" card * Fix scroll for "user activity" card * Revert "Fix scroll for "user activity" card" This reverts commit 4d793b1. * Revert "Fix scrollbar for "traffic" card" This reverts commit b00da0d. * Fix scroll for nb-list inside nb-card * chore(readme): add material theme description * Remove unused angular2-toaster package * chore(readme): add material theme images * chore(readme): update text * Upgrade to @nebular 5 release * feat: update ng2-smart-table to 1.6 * chore(readme): add info about material theme branch * fix: put Material theme in front of others Otherwise Material theme style override Nebular * refactor(material): remove options list border radius * refactor: material input new look * fix(form-inputs): show material inputs * feat(material): change inputs style * refactor: improve observable layout change sharing * feat: add safe delayed event of layout change * fix: replace change layout with safe change * fix: limit front card width to prevent map overflow before repaint * build: starter-kit clean up * feat: upgrade to angular 9 Co-authored-by: David Henley <henleydr@gmail.com> Co-authored-by: Sergey Andrievskiy <yggg@users.noreply.github.com> Co-authored-by: Leon Lafayette <me@le0n.io> Co-authored-by: Vladimir Lugovsky <lugovsky.v@gmail.com> Co-authored-by: Sergey Andrievskiy <s.andrievskiy@akveo.com> Co-authored-by: Evgeny Lupanov <elupanov@users.noreply.github.com> Co-authored-by: eugene-sinitsyn <e.sinitsyn.s@akveo.com> Co-authored-by: Evgeny Lupanov <e.lupanov@akveo.com> Co-authored-by: sashaqred <sashaqred@ya.ru> Co-authored-by: Dmitry Nehaychik <4dmitr@gmail.com> Co-authored-by: Maksim Karatkevich <m.karatkevich@akveo.com>
yggg
added a commit
that referenced
this pull request
Oct 8, 2020
BREAKING CHANGE: `@akveo/ng2-completer` dependency replaced by ng2-completer as original package was fixed. Note on why we have to fork package could be found [here](#1140 (comment)). Please, uninstall `@akveo/ng2-completer` and install `ng2-completer`: ``` npm uninstall --save @akveo/ng2-completer npm install ng2-completer ```
DevStar0804
pushed a commit
to DevStar0804/angular-shoppingcart
that referenced
this pull request
Aug 1, 2021
… (#5694) * chore: update README for extra theme (#5466) * fix(tinymce): set absolute path for skin url (#5491) * feat: add calendar with week numbers example (#5515) * chore(readme): update bundles section text * fix(forms): add missing forms module import (#5530) * feat: update Nebular to 4.4.0 (#5533) * chore(readme): update bundles image (#5565) * chore: add bundles black friday deal (#5569) * chore(readme): update black friday 2019 image (#5570) * chore(readme): remove bundles discounts image (#5574) * chore(readme): update bundles image (#5575) * feat(seo): add canonical tag (#5578) * chore(analytics): add proper analytics tracking URLs (#5604) * feat: Material theme * feat: upgrade to Angular 9 and Nebular 5 (#5628) BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)). * Upgrade to the latest minor version of Angular * Upgrade to the latest major version of Angular * Upgrade to nebular 5 beta, remove "angular-tree-component" package * Remove packages uncompatible with Ivy * Fix post-upgrade errors * Replace @agm/core with @angular/google-maps * Fix search-map component using @angular/google-maps * Move material theme files from @nebular * Add missing images and change fg text color of dark material theme to bright white * Implement ripple effect for material themes * Add material style overrides * Add ripple effects to controls across application * Configure material theme, add material button and input examples * Add toggle button example * Fix lint warnings * Add material menu icon for material themes * Fix lint warnings for styles * Set menu font-weight to normal for material themes * Add "hover" and "active" styles for material menu * Update material styles * Override input styles for material themes * Override select styles for material themes * Hide rounded inputs for material themes * Update material styles * Remove non-material themes * Revert "Remove non-material themes" This reverts commit c2e3194. * Fix actions color * Fix lint warnings * Fix scrollbar for "traffic" card * Fix scroll for "user activity" card * Revert "Fix scroll for "user activity" card" This reverts commit 4d793b1. * Revert "Fix scrollbar for "traffic" card" This reverts commit b00da0d. * Fix scroll for nb-list inside nb-card * chore(readme): add material theme description * Remove unused angular2-toaster package * chore(readme): add material theme images * chore(readme): update text * Upgrade to @nebular 5 release * feat: update ng2-smart-table to 1.6 * chore(readme): add info about material theme branch * fix: put Material theme in front of others Otherwise Material theme style override Nebular * refactor(material): remove options list border radius * refactor: material input new look * fix(form-inputs): show material inputs * feat(material): change inputs style * refactor: improve observable layout change sharing * feat: add safe delayed event of layout change * fix: replace change layout with safe change * fix: limit front card width to prevent map overflow before repaint * build: starter-kit clean up * feat: upgrade to angular 9 Co-authored-by: David Henley <henleydr@gmail.com> Co-authored-by: Sergey Andrievskiy <yggg@users.noreply.github.com> Co-authored-by: Leon Lafayette <me@le0n.io> Co-authored-by: Vladimir Lugovsky <lugovsky.v@gmail.com> Co-authored-by: Sergey Andrievskiy <s.andrievskiy@akveo.com> Co-authored-by: Evgeny Lupanov <elupanov@users.noreply.github.com> Co-authored-by: eugene-sinitsyn <e.sinitsyn.s@akveo.com> Co-authored-by: Evgeny Lupanov <e.lupanov@akveo.com> Co-authored-by: sashaqred <sashaqred@ya.ru> Co-authored-by: Dmitry Nehaychik <4dmitr@gmail.com> Co-authored-by: Maksim Karatkevich <m.karatkevich@akveo.com>
DevStar0804
pushed a commit
to DevStar0804/angular-shoppingcart
that referenced
this pull request
Aug 1, 2021
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
nikita-fuchs
pushed a commit
to aeternity/ae-token-minter
that referenced
this pull request
Dec 9, 2022
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
bolt0111
pushed a commit
to bolt0111/admin_angular
that referenced
this pull request
Feb 8, 2023
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
megaStar277
pushed a commit
to megaStar277/ngx-admin
that referenced
this pull request
Jun 16, 2023
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
protono
pushed a commit
to protono/pw-practice-app
that referenced
this pull request
Oct 2, 2023
BREAKING CHANGE: Angular updated to version 9. Nebular updated to version 5. `@agm/core` replaced with `@angular/google-maps`. `ng2-completer` replaced with `@akveo/ng2-completer`, read details [here](akveo/ng2-smart-table#1140 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tables to Angular 9.
We have to replace
ng2-completerwith@akveo/ng2-completerbecause original completer is published with two major issues (first issue, second issue).@akveo/ng2-completerpackage is ang2-completer@9.0.0package built with fixes from oferh/ng2-completer#448. This is a temporary measure until the original ng2-completer fixed. We have no plans to support@akveo/ng2-completer.BREAKING CHANGE:
ng2-completerdependency replaced by@akveo/ng2-completer. Read details in feat: upgrade to Angular 9 #1140. This is a temporary measure until the original ng2-completer fixed. We have no plans to support@akveo/ng2-completer.listed a peerDependency. This matches Angular framework.