Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add Eva section #1552

Merged
merged 6 commits into from
Jun 3, 2019
Merged

feat(docs): add Eva section #1552

merged 6 commits into from
Jun 3, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jun 2, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@yggg yggg requested a review from nnixaa June 2, 2019 11:33
</div>
<div class="images">
<img class="theme-colors"
src="/assets/img/theme-colors.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that image srcs are not correct

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9f451b2

Eva Design System
</h2>
<p class="text">Construct consistent & scalable interface using basic components following Eva Guidelines and it will always have stunning design. </p>
<a class="learn-more" nbButton size="giant">Learn more about Eva</a>
Copy link
Collaborator

@nnixaa nnixaa Jun 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

href="https://eva.design"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b4f17d5

docs/app/@theme/components/eva/eva.component.html Outdated Show resolved Hide resolved
@yggg yggg requested a review from nnixaa June 2, 2019 16:40
@yggg yggg merged commit 1209d65 into akveo:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants