-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): Eva style #1391
Merged
Merged
feat(select): Eva style #1391
Changes from 9 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
c6ca022
feat(select): use common shape, size and status types
yggg a82fd74
feat(select): use nb-icon for arrow
yggg 4e85e95
refactor(select): remove named inputs
yggg 5e885fd
fix(select): import icon module
yggg 33ef96a
refactor(select): boolean attributes for appearance, width and multiple
yggg 4ddee44
refactor(option): remove named input
yggg f0f99c7
feat(select): add missing 'filled' appearance input
yggg e7cc521
refactor(select): move open class to host
yggg 1f548c1
refactor(select): use native button
yggg 6c73390
refactor(select): remove unnecessary undefined selection model check
yggg 9fc9b46
refactor(select): use ngIfElse syntax
yggg 06a5454
refactor(option): change disabled class to attribute
yggg d7f0242
refactor(option): make fields protected
yggg 199e7d9
feat(select): add size, shape and status class bindings
yggg d7d0d1f
refactor(select): use ngIfElse syntax
yggg dc69928
fix(select): update button selector
yggg dc83f39
docs(select): wrap examples into card
yggg a625c63
docs(select): add all combinations
yggg 5846361
feat(select): add Eva outline and filled style
yggg ff01751
docs(select): add missing appearance binding
yggg f1db824
docs(select): change combinations into interactive example
yggg 8304687
fix(select): use status theme variable
yggg 8245037
feat(select): add hero status
yggg 4cf708a
docs(select): add button to select disabled option
yggg 8e5bc4b
refactor(option group): remove unnecessary style
yggg 5abae6f
feat(select): add missing animation properties
yggg 1cb16ef
fix(select): remove broken scss
yggg 8f658cc
refactor(select): remove unused import
yggg 289add0
fix(select): add missing methods
yggg d817d4e
refactor: remove commented lines
yggg 012f3b1
Merge branch 'next' into feat/eva-select
yggg 5bbeaf6
refactor(select): use common name for theme file
yggg 97b7e1f
fix(select): update property name
yggg 7ca9085
docs(select): update theme properties list
yggg 4648ced
fix(select): correct file path
yggg 4febc47
Merge branch 'next' into feat/eva-select
yggg 02144b0
fix(select): align text to start
yggg 1de27ed
docs(select): show appearance name
yggg d125dfa
fix(select): change icons size with font size
yggg f08db69
feat(select): add min width theme property
yggg ddc5625
fix(select): add missing full width class
yggg c47dd87
feat(select): add min width theme property
yggg b26e292
fix(select): change icon placement based on document direction
yggg 2a7b147
docs(select interactive example): put configuration card on own row
yggg 15a38e3
feat(select): increase min width
yggg 75185f8
docs(select): include interactive example into docs
yggg 928b413
docs(select interactive): fix scrolling
yggg 43a3c98
refactor(select): make option look same across appearances
yggg fb1293a
refactor(select): make option look same across appearances
yggg 62b7c05
docs(select): refactor interactive example
yggg c8eeb89
refactor(select): add parentheses
nnixaa 3fc377b
docs(select): update sizes example
yggg d4b6158
docs(select): remove status from placeholder example
yggg 0890f6b
docs(select): add common example styles
yggg 4e12e51
fix(select): appearance setting
yggg 8c3624f
docs(select): update sizes count
yggg c665d02
docs(select): replace outline with filled
yggg f8c5de6
Merge branch 'next' into feat/eva-select
yggg 7346978
Merge branch 'next' into feat/eva-select
yggg f20a192
refactor(select): add parentheses
yggg 1d11e41
Merge branch 'next' into feat/eva-select
yggg a5091e8
docs(select): update theme properties list
yggg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,7 +108,7 @@ | |
} | ||
} | ||
|
||
@include select-outline; | ||
@include select-outline(); | ||
@include select-filled; | ||
@include select-hero; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
nb-card-body { | ||
display: flex; | ||
flex-direction: column; | ||
align-items: start; | ||
} | ||
|
||
nb-select:not(:only-child):not(:last-child) { | ||
margin-bottom: 1rem; | ||
} |
10 changes: 5 additions & 5 deletions
10
...yout/select/select-outline.component.html → ...ayout/select/select-filled.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/playground/with-layout/select/select-placeholder.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 1 addition & 22 deletions
23
src/playground/with-layout/select/select-sizes.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, how about the others?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed f20a192