Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(month picker): prevent duplicates #1377

Merged
merged 4 commits into from
Apr 11, 2019
Merged

fix(month picker): prevent duplicates #1377

merged 4 commits into from
Apr 11, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Apr 11, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1195

@yggg yggg requested a review from nnixaa April 11, 2019 10:21
@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #1377 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
+ Coverage   81.11%   81.16%   +0.05%     
==========================================
  Files         232      232              
  Lines        7054     7057       +3     
  Branches      599      599              
==========================================
+ Hits         5722     5728       +6     
+ Misses       1156     1153       -3     
  Partials      176      176
Impacted Files Coverage Δ
...ar-month-picker/calendar-month-picker.component.ts 86.11% <100%> (+10.35%) ⬆️

})
});

it('should not has duplicate months', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not have :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e690806

@yggg yggg requested a review from nnixaa April 11, 2019 11:12
@yggg yggg merged commit 47aff73 into akveo:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbDatepicker "next month" skips one month
2 participants