Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark name flag as required #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nitishfy
Copy link
Member

This PR does the following changes:

  1. The name flag as required for mta helmrelease and mta kustomization command. The --namespace flag has a default value of flux-system namespace, hence if a user never initialize that flag, this flag will never be nil. So there's no point of checking if the --namespace flag has a nil value.
  2. Remove the MarkPersistentFlag() from the subcommands.
  3. Instead of printing the version in the JSON format, simply print the version in the string format without marshalling. In other words, marshalling is not required when printing the version of mta.

After

image
image

Signed-off-by: nitishfy <justnitish06@gmail.com>

mark flags required

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant