docs: Azure DevOps support for PRs #3540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3540 +/- ##
=======================================
Coverage 52.49% 52.49%
=======================================
Files 295 295
Lines 26744 26744
=======================================
Hits 14038 14038
Misses 11936 11936
Partials 770 770 ☔ View full report in Codecov by Sentry. |
krancour
reviewed
Feb 22, 2025
Comment on lines
+13
to
+14
| At present, this feature only supports GitHub, Gitea and Azure DevOps pull | ||
| requests, and GitLab merge requests. |
There was a problem hiding this comment.
It always bugs me that GitLab calls them merge requests.
I think as this list grows, the "and GitLab merge requests" at the end feels more and more awkward.
What would you think about this?
Suggested change
| At present, this feature only supports GitHub, Gitea and Azure DevOps pull | |
| requests, and GitLab merge requests. | |
| At present, this feature only supports GitHub, Gitea, Azure DevOps, and | |
| GitLab pull/merge requests. |
LGTM either way.
krancour
approved these changes
Feb 22, 2025
|
Nice catch. |
krancour
reviewed
Feb 22, 2025
|
|
||
| ## Configuration | ||
|
|
||
| | Name | Type | Required | Description | | ||
| |------|------|----------|-------------| | ||
| | `repoURL` | `string` | Y | The URL of a remote Git repository. | | ||
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab` and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | | ||
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab`, `azure` and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | |
There was a problem hiding this comment.
Slight preference for an Oxford comma, but in the end, I don't care that much. Same in the wait-for-pr step docs.
Suggested change
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab`, `azure` and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | | |
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab`, `azure`, and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | |
krancour
reviewed
Feb 22, 2025
| @@ -14,7 +14,7 @@ and is commonly followed by an `argocd-update` step. | |||
| | Name | Type | Required | Description | | |||
| |------|------|----------|-------------| | |||
| | `repoURL` | `string` | Y | The URL of a remote Git repository. | | |||
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab` and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | | |||
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab`, `azure` and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | | |||
There was a problem hiding this comment.
Suggested change
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab`, `azure` and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | | |
| | `provider` | `string` | N | The name of the Git provider to use. Currently only `github`, `gitlab`, `azure`, and `gitea` are supported. Kargo will try to infer the provider if it is not explicitly specified. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow appears to have disappeared from the documentation, potentially during our documentation restructuring.