feat: allow opt-in to credentials over HTTP #3539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=======================================
Coverage 52.49% 52.49%
=======================================
Files 295 295
Lines 26744 26744
=======================================
Hits 14038 14038
Misses 11936 11936
Partials 770 770 ☔ View full report in Codecov by Sentry. |
|
cc @tal-hason, you get your wish from #2198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we have not allowed the credentials database to do lookups for HTTP URLs out of security considerations. However, in some scenarios, this may still be useful as long as the user is aware of the implications.
To facilitate this, add an
ALLOW_CREDENTIALS_OVER_HTTPenvironment variable which allows looking up credentials for HTTP URLs, and wire this into the chart.Follow up to #3530