feat: conditional step execution #3485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
+ Coverage 52.27% 52.47% +0.20%
==========================================
Files 290 294 +4
Lines 26330 26696 +366
==========================================
+ Hits 13764 14009 +245
- Misses 11814 11917 +103
- Partials 752 770 +18 ☔ View full report in Codecov by Sentry. |
00ac6e1 to
3a7e773
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
3a7e773 to
d6f6872
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
d6f6872 to
63afbf1
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
krancour
reviewed
Feb 22, 2025
Comment on lines
+210
to
+212
| // If is an optional expression that, if present, must evaluate to a boolean | ||
| // value. If the expression evaluates to false, the step will be skipped. | ||
| If string `json:"if,omitempty" protobuf:"bytes,7,opt,name=if"` |
There was a problem hiding this comment.
Would it be worth describing what happens if it doesn't evaluate to a boolean? As a reader who hasn't looked at the code, I might wonder if it's an error or is implicitly false.
|
LGTM with one minor suggestion about docs. |
krancour
approved these changes
Feb 22, 2025
|
Also love how the expression support continues to pay dividends! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3125