fix(chart): set divisor for resourceFieldRefs
#3445
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are all set to one, based on the Kubernetes documentation[1] that states: > The `divisor` field is optional and has the default value of `1`. > A divisor of `1` means cores for cpu resources, or bytes for memory > resources. [1]: https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/#store-container-fields Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
krancour
approved these changes
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3445 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 290 290
Lines 26286 26286
=======================================
Hits 13744 13744
Misses 11793 11793
Partials 749 749 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Hidde Beydals <hidde@hhh.computer> (cherry picked from commit 1aa0882)
|
Successfully created backport PR for |
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Feb 6, 2025
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3444
They are all set to one, based on the Kubernetes documentation1 that states: