-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): fix list ops in authorizing client #3396
Conversation
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
- Coverage 52.50% 52.49% -0.02%
==========================================
Files 291 291
Lines 26625 26631 +6
==========================================
Hits 13979 13979
- Misses 11882 11888 +6
Partials 764 764 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com> (cherry picked from commit ae7213f)
Successfully created backport PR for |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Fixes #3296
Only the API server was affected by this.
When listing any sort of resource using our authorizing client wrapper, the following worked fine:
But the following did not:
In the former case, the authorizing client wrapper would fail to glean namespace info from the options, resulting in the query not being constrained by namespace, and thus requiring the user to have cluster-scoped read on the affected types.