Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertical view for secrets and filter credentials by label #3392

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Jan 29, 2025

fixes #3294 and API of credentials was previously returning generic secrets

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from a team as a code owner January 29, 2025 08:28
@Marvin9 Marvin9 requested a review from krancour January 29, 2025 08:28
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 86003f7
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6799e6a2a7121c000827b08b
😎 Deploy Preview https://deploy-preview-3392.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 52.46%. Comparing base (d1441f1) to head (86003f7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/api/list_credentials_v1alpha1.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3392      +/-   ##
==========================================
- Coverage   52.50%   52.46%   -0.04%     
==========================================
  Files         291      291              
  Lines       26625    26643      +18     
==========================================
  Hits        13979    13979              
- Misses      11882    11900      +18     
  Partials      764      764              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marvin9 Marvin9 requested a review from hiddeco January 29, 2025 09:21
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Marvin9 Marvin9 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 0a0f08a Jan 30, 2025
25 of 27 checks passed
@Marvin9 Marvin9 deleted the Marvin9/fix-secrets-ui branch January 30, 2025 03:54
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
(cherry picked from commit 0a0f08a)
@akuitybot
Copy link

Successfully created backport PR for release-1.2:

fykaa pushed a commit to fykaa/kargo that referenced this pull request Feb 6, 2025
…y#3392)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret management should not require horizontal scrolling in table
3 participants