Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.1): fix: fix faulty logic for handling possible double-encoding of github app private key #3378

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

akuitybot
Copy link

Automated backport to release-1.1, triggered by a label in #3363.

… app private key (#3363)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit f28ce2f)
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit f2e3445
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6797eab72ebc0d000874ab7c
😎 Deploy Preview https://deploy-preview-3378.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour added this to the v1.1.3 milestone Jan 27, 2025
@krancour krancour enabled auto-merge (squash) January 27, 2025 20:23
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.19%. Comparing base (5c875fe) to head (f2e3445).
Report is 1 commits behind head on release-1.1.

Files with missing lines Patch % Lines
internal/credentials/kubernetes/github/app.go 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1    #3378      +/-   ##
===============================================
+ Coverage        51.17%   51.19%   +0.01%     
===============================================
  Files              285      285              
  Lines            25627    25639      +12     
===============================================
+ Hits             13115    13126      +11     
  Misses           11814    11814              
- Partials           698      699       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour merged commit 2d9d75e into release-1.1 Jan 27, 2025
23 checks passed
@krancour krancour deleted the backport-3363-to-release-1.1 branch January 27, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants