Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.2): refactor: change generic secret label #3350

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

akuitybot
Copy link

Automated backport to release-1.2, triggered by a label in #3331.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit 95ae6a6)
@krancour krancour enabled auto-merge (squash) January 23, 2025 17:43
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit af05864
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67927fa14ebd3600083414f6
😎 Deploy Preview https://deploy-preview-3350.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour added this to the v1.2.1 milestone Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 83.87097% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.47%. Comparing base (b934ffa) to head (af05864).
Report is 1 commits behind head on release-1.2.

Files with missing lines Patch % Lines
internal/api/delete_project_secret_v1alpha1.go 25.00% 2 Missing and 1 partial ⚠️
internal/api/list_project_secrets_v1alpha1.go 86.36% 2 Missing and 1 partial ⚠️
internal/directives/simple_engine_promote.go 89.28% 2 Missing and 1 partial ⚠️
internal/api/update_project_secret_v1alpha1.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2    #3350      +/-   ##
===============================================
+ Coverage        52.02%   52.47%   +0.45%     
===============================================
  Files              295      291       -4     
  Lines            26763    26617     -146     
===============================================
+ Hits             13923    13968      +45     
+ Misses           12078    11886     -192     
- Partials           762      763       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour merged commit 29b0790 into release-1.2 Jan 23, 2025
25 checks passed
@krancour krancour deleted the backport-3331-to-release-1.2 branch January 23, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants