Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): restrict common flags to subcommands branches where they're applicable #1360

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Jan 3, 2024

Fixes #1353

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit be15fdd
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/659d9afb33a75f00090e31c1
😎 Deploy Preview https://deploy-preview-1360.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour added this to the v0.4.0 milestone Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8f03cfd) 45.44% compared to head (be15fdd) 45.43%.

Files Patch % Lines
internal/cli/cmd/login/login.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
- Coverage   45.44%   45.43%   -0.01%     
==========================================
  Files         136      136              
  Lines       11718    11719       +1     
==========================================
  Hits         5325     5325              
- Misses       6202     6203       +1     
  Partials      191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour marked this pull request as ready for review January 9, 2024 19:12
@krancour krancour requested a review from a team as a code owner January 9, 2024 19:12
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this pull request to the merge queue Jan 9, 2024
Merged via the queue into akuity:main with commit 81bcdd9 Jan 9, 2024
14 of 16 checks passed
@krancour krancour deleted the krancour/cli-3 branch January 9, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

root level "persistent flags" that maybe shouldn't be root level
2 participants