Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): update docs for v0.3.0 #1302

Merged
merged 10 commits into from
Dec 22, 2023
Merged

feat(docs): update docs for v0.3.0 #1302

merged 10 commits into from
Dec 22, 2023

Conversation

krancour
Copy link
Member

@krancour krancour commented Dec 19, 2023 •
edited
Loading

Fixes #1185

This should not be merged until after v0.3.0 is released.

@krancour krancour added this to the v0.3.0 milestone Dec 19, 2023
@krancour krancour self-assigned this Dec 19, 2023
@krancour krancour requested review from a team as code owners December 19, 2023 19:47
@netlify Netlify
Copy link

netlify bot commented Dec 19, 2023 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 39b928f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6585a62dc8aa4500089ab595
😎 Deploy Preview https://deploy-preview-1302.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour marked this pull request as draft December 19, 2023 19:48
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19deade) 45.84% compared to head (39b928f) 45.84%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-0.3    #1302   +/-   ##
============================================
  Coverage        45.84%   45.84%           
============================================
  Files              135      135           
  Lines            11560    11560           
============================================
  Hits              5300     5300           
  Misses            6069     6069           
  Partials           191      191

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour force-pushed the krancour/doc-updates branch 2 times, most recently from 491b157 to 3b7c853 Compare December 21, 2023 23:16
@krancour krancour changed the base branch from main to release-0.3 December 21, 2023 23:16
@krancour krancour force-pushed the krancour/doc-updates branch 2 times, most recently from 6cc55c4 to 8fdbd39 Compare December 22, 2023 00:01
@krancour
document verifications
9f6fb8b 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
document global credentials option
855c222 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
document the dependency on argo rollouts
e745597 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
update versions of dependencies that installation instructions have b…
788b773 
…een tested with

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/doc-updates branch 2 times, most recently from 4b92fe0 to 3b68f65 Compare December 22, 2023 02:08
@krancour krancour marked this pull request as ready for review December 22, 2023 02:13
@krancour
update quickstart scripts to install argo rollouts
cc628f2 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
update quickstart doc to mention scripts will install rollouts
363366d 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
update quickstart with v0.3.0-compatible CLI commands and updated exa…
e9b590a 
…mple output

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
document sso user --> serviceaccount mappings
864aab1 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/doc-updates branch from 3b68f65 to 864aab1 Compare December 22, 2023 02:20
devholic
devholic approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@devholic devholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

jessesuen
jessesuen reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only feedback is agreement with hoon's suggestion to install into argo-rollouts, which is more common.

jessesuen
jessesuen approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well written. Thank you!

@krancour
upgrade argo rollouts to chart versions 2.33.0
f68ec80 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
change release name and namespace from rollouts to argo-rollouts
39b928f 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour enabled auto-merge (squash) December 22, 2023 15:08
@krancour krancour merged commit 13ae37d into akuity:release-0.3 Dec 22, 2023
15 checks passed
@krancour krancour deleted the krancour/doc-updates branch January 8, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devholic devholic devholic approved these changes

@jessesuen jessesuen jessesuen approved these changes

Assignees

@krancour krancour

Labels
area/documentation do not merge yet kind/enhancement priority/normal
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

document new v0.3.0 features and breaking changes
3 participants
@krancour @devholic @jessesuen