Skip to content

Commit

Permalink
chore(backport release-1.1): fix: warehouse branch regex that was to …
Browse files Browse the repository at this point in the history
…limiting (#3241)

Co-authored-by: Tal Hason <thason@redhat.com>
  • Loading branch information
akuitybot and tal-hason authored Jan 10, 2025
1 parent 4deb9ff commit 3b9f462
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/v1alpha1/warehouse_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ type GitSubscription struct {
// subscription is implicitly to the repository's default branch.
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:Pattern=`^\w+([-/]\w+)*$`
// +kubebuilder:validation:Pattern=`^\w+([-/\.]\w+)*$`
Branch string `json:"branch,omitempty" protobuf:"bytes,3,opt,name=branch"`
// StrictSemvers specifies whether only "strict" semver tags should be
// considered. A "strict" semver tag is one containing ALL of major, minor,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ spec:
CommitSelectionStrategy is NewestFromBranch or unspecified), the
subscription is implicitly to the repository's default branch.
minLength: 1
pattern: ^\w+([-/]\w+)*$
pattern: ^\w+([-/\.]\w+)*$
type: string
commitSelectionStrategy:
default: NewestFromBranch
Expand Down
2 changes: 1 addition & 1 deletion ui/src/gen/schema/warehouses.kargo.akuity.io_v1alpha1.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"branch": {
"description": "Branch references a particular branch of the repository. The value in this\nfield only has any effect when the CommitSelectionStrategy is\nNewestFromBranch or left unspecified (which is implicitly the same as\nNewestFromBranch). This field is optional. When left unspecified, (and the\nCommitSelectionStrategy is NewestFromBranch or unspecified), the\nsubscription is implicitly to the repository's default branch.",
"minLength": 1,
"pattern": "^\\w+([-/]\\w+)*$",
"pattern": "^\\w+([-/\\.]\\w+)*$",
"type": "string"
},
"commitSelectionStrategy": {
Expand Down
2 changes: 1 addition & 1 deletion ui/src/gen/v1alpha1/generated_pb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1575,7 +1575,7 @@ export class GitSubscription extends Message<GitSubscription> {
* subscription is implicitly to the repository's default branch.
*
* +kubebuilder:validation:MinLength=1
* +kubebuilder:validation:Pattern=`^\w+([-/]\w+)*$`
* +kubebuilder:validation:Pattern=`^\w+([-/\.]\w+)*$`
*
* @generated from field: optional string branch = 3;
*/
Expand Down

0 comments on commit 3b9f462

Please sign in to comment.