Generate http request body in Atgen #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaos
suggested changes
Sep 3, 2019
lib/generator.go
Outdated
| err = errors.WithStack(internalErr) | ||
| return false | ||
| } | ||
| h, _ := parser.ParseExpr(fmt.Sprintf("%#v", body)) |
There was a problem hiding this comment.
これだと前のリクエストの結果をつかって動的にリクエストを組み立てるということが出来なさそう？
(コード見る限り前も出来なかったのでは無いかという感じはあるけど
今後そういう事はやりたいと思っているので、atgen で構築した文字列を test codeを埋め込むのではなく、
json であれば json.Marshal するコードを埋め込むようにしたい。
There was a problem hiding this comment.
確かに。今の実装だとそれができなくなってしまいますね。
There was a problem hiding this comment.
json.Marshal を埋め込むように変更しました。
これだと前のリクエストの結果をつかって動的にリクエストを組み立てるということが出来なさそう？
こちらも組み立てられるようにし、確認用に実際のexampleも追加しました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Close #17
What
HTTPのリクエストボディをAtgen内で行うように変更する。