Cache results of packges.Load() to shorten execution time #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaos
approved these changes
May 13, 2019
lib/parser.go
Outdated
| @@ -193,18 +193,25 @@ func isRelativePath(path string) bool { | |||
| return strings.HasPrefix(path, ".") | |||
| } | |||
|
|
|||
| var packageCache map[string][]*packages.Package = map[string][]*packages.Package{} | |||
There was a problem hiding this comment.
Suggested change
| var packageCache map[string][]*packages.Package = map[string][]*packages.Package{} | |
| var packageCache = map[string][]*packages.Package{} |
たぶんこちらで十分かと思います
There was a problem hiding this comment.
なるほど、こう書けるのですね、ありがとうございます！
修正いたしました。
sachaos
approved these changes
May 13, 2019
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subierのテスト生成に1分以上時間がかかり、調べてみたところ
validateRouterFuncs()内のpackages.Load(conf, "net/http", routerFunc.PackagePath)が何度も実行されていて遅い、ということがわかったので、実行結果をrouterFunc.PackagePath毎にキャッシュして使い回すようにしてみました。修正前
修正後
@sachaos 時間ありましたらざっと見ておいていただけると助かります:pray: