Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API Documentation & Added fix for replace Tabbed Component #2364

Merged
merged 5 commits into from
Sep 11, 2017

Conversation

mcabs3
Copy link
Collaborator

@mcabs3 mcabs3 commented Sep 10, 2017

No description provided.

- Fixed tab in drawer bug
- Added modal and lightbox examples with distinguished styling
- Added Base classes for ease of implementation
- Added prop-types as Example dependencies
- Small RN updates to match eslint standards
This commit fixes a bug for calling replace or ActionConst.REPLACE for a scene that has the tabs property.
The bug would show the "push" animation and not properly navigate to the tabbed scene.
@mcabs3 mcabs3 changed the title Updated API Documentation Updated API Documentation & Added fix for replace Tabbed Component Sep 10, 2017
@mcabs3
Copy link
Collaborator Author

mcabs3 commented Sep 10, 2017

@aksonov I updated the docs from the notes from previous issues, and I also added a separate commit for the replace issue for Tab components since the other PR wasn't passing the CircleCI tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants