Return None result if no wordnumbers found, print error. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bpben . I am glad you found my library useful. And yes, you are contributing at the correct place. Forking, editing and merging is the correct way to contribute. Regarding the pull request, I am a bit busy right now (working on a new open source project), but I will definitely see your suggested modification and will decide whether this is needed for a wider use case or not. If it is, it will be included in the next release. Keep contributing! |
|
@bpben Added None result and printing of error. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I ran into an issue with the new fix to the IndexError problem. I had w2n incorporated into a function of mine and counted on an IndexError to move on to the next part. With the printed error, I was getting that error message returned as part of the function's result. I tried making a quick fix of that, having it print the error instead and return a None result.
Is that helpful? I'm a bit of a git newbie, so let me know if I'm contributing incorrectly here. Thanks for a useful library!