Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't camelCase CSS custom properties #145

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Don't camelCase CSS custom properties #145

merged 1 commit into from
Apr 7, 2023

Conversation

tylersticka
Copy link

@tylersticka tylersticka commented Mar 13, 2023 •
edited
Loading

The current camel case logic for inline style keys invalidates custom property rules in inline styles. This change checks to make sure the key doesn't start with -- before processing it with camelCase.

See #144

@coveralls
Copy link

coveralls commented Apr 7, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling 3e6aae7 on cloudfour:fix/custom-props into 945ed72 on aknuds1:master.

aknuds1
aknuds1 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Owner

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry for the tardy review :/

@aknuds1 aknuds1 merged commit a195ea9 into aknuds1:master Apr 7, 2023
@aknuds1 aknuds1 mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylersticka @coveralls @aknuds1