Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure event handlers are functions #126

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Conversation

aknuds1
Copy link
Owner

@aknuds1 aknuds1 commented May 2, 2021

Make sure event handlers, f.ex. "onclick", are functions.

Fixes #101.

@aknuds1 aknuds1 marked this pull request as draft May 2, 2021 08:42
@aknuds1 aknuds1 added the bug label May 2, 2021
@aknuds1 aknuds1 mentioned this pull request May 2, 2021
@aknuds1 aknuds1 force-pushed the bugfix/onclick-function branch from fe37ee4 to e83c0cf Compare May 2, 2021 08:53
@pauloortins
Copy link

@aknuds1 Any idea when you will merge this PR?

@aknuds1 aknuds1 force-pushed the bugfix/onclick-function branch from 7c1309d to 3117303 Compare September 16, 2021 10:22
@aknuds1
Copy link
Owner Author

aknuds1 commented Sep 16, 2021

@pauloortins it must first be made to work. The problem isn't easy to solve.

@aknuds1 aknuds1 force-pushed the bugfix/onclick-function branch from 3117303 to 7bc44b3 Compare September 16, 2021 10:58
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 force-pushed the bugfix/onclick-function branch from 7bc44b3 to baffd3e Compare September 16, 2021 12:46
@aknuds1 aknuds1 marked this pull request as ready for review September 16, 2021 12:46
@aknuds1 aknuds1 merged commit 72b2ed1 into master Sep 16, 2021
@aknuds1 aknuds1 deleted the bugfix/onclick-function branch September 16, 2021 12:46
@aknuds1
Copy link
Owner Author

aknuds1 commented Sep 16, 2021

@pauloortins I merged the PR now, since the outstanding issue was testing React HTML output with onClick property, and I simply couldn't get that to work (React doesn't render it to HTML).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid event handler property onclick. Did you mean onClick?
3 participants