Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shard failed to unwrap buffered messages correctly #7452

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix code error
  • Loading branch information
Arkatufus committed Jan 10, 2025
commit 5a1d3204c168dc88013dcf5178b6927045d06c61
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ protected override void OnReceive(object message)
}
}

#endregion
private sealed class FakeRememberEntitiesProvider: IRememberEntitiesProvider
{
private readonly IActorRef _probe;
Expand Down Expand Up @@ -93,7 +92,7 @@ private class FakeShardStoreActor : ActorBase
private readonly string _shardId;
private readonly IActorRef _probe;

private FakeShardStoreActor(string shardId, IActorRef probe)
public FakeShardStoreActor(string shardId, IActorRef probe)
{
_shardId = shardId;
_probe = probe;
Expand All @@ -119,7 +118,7 @@ private class FakeCoordinatorStoreActor : ActorBase
{
public static Props Props() => Actor.Props.Create(() => new FakeCoordinatorStoreActor());

private FakeCoordinatorStoreActor()
public FakeCoordinatorStoreActor()
{
Context.System.EventStream.Publish(new CoordinatorStoreCreated(Context.Self));
}
Expand Down Expand Up @@ -158,6 +157,8 @@ private static Config GetConfig()
.WithFallback(ClusterSingleton.DefaultConfig());
}

#endregion

private readonly IActorRef _shard;
private IActorRef _store;

Expand Down Expand Up @@ -194,6 +195,8 @@ public WrappedShardBufferedMessageSpec(ITestOutputHelper output) : base(GetConfi
[Fact(DisplayName = "Message wrapped in ShardingEnvelope, buffered by Shard, must arrive in entity actor")]
public async Task WrappedMessageDelivery()
{
IgnoreMessages<ShardRegion.StartEntityAck>();

var continueMessage = await ExpectShardStartup();

// this message should be buffered
Expand Down