Tentative nullref fix for LogSource
#7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
reviewed
Jan 31, 2024
src/core/Akka/Event/Logging.cs
Outdated
Comment on lines
110
to
115
| var defaultAddress = system.AsInstanceOf<ExtendedActorSystem>().Provider.DefaultAddress; | ||
| if (defaultAddress is null) | ||
| { | ||
| return a.Path.ToString(); | ||
| } | ||
| return a.Path.ToStringWithAddress(defaultAddress); |
There was a problem hiding this comment.
This can be simplified by removing the try...catch block altogether
Arkatufus
approved these changes
Jan 31, 2024
|
Oh, I'm glad I was helpful (and will be happy to not see this exception anymore). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6966
Changes
Please provide a brief description of the changes here.
As mentioned here I'm getting this error 100% of times when starting the application that's configure to use Akka.Remoting.
Looking at the source code it seems to me that there's a race between Remoting and the Logging configuration.
Apparently the logging always wins the race and consequently throws a nullref. This exception is swallowed but I was wondering if the suggested fix may be of any value since it's unlikely that the remoting system may successfully configure (this is an educated guess) after the introduced null check because the offending path has only:
Before throwing the nullref, also since the fallback is exactly the same as what the null path takes in my PR, I think that removing the start-up exception may valuable, but I'm not an expert in Akka source and I may be missing out here.
@Arkatufus FYI since you responded in the aforementioned issue.