Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[67-74] UnfoldResourceSourceSpec #6615

Merged
merged 8 commits into from
Mar 30, 2023
Merged

[67-74] UnfoldResourceSourceSpec #6615

merged 8 commits into from
Mar 30, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 26, 2023

Changes

  • Change AssertAllStagesStopped to AssertAllStagesStoppedAsync

Aaronontheweb
Aaronontheweb requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async testkit APIs instead of work-arounds

src/core/Akka.Streams.Tests/Dsl/UnfoldResourceSourceSpec.cs Outdated
@@ -90,51 +89,51 @@ public void A_UnfoldResourceSource_must_read_contents_from_a_file()

sub.Request(1);
c.ExpectComplete();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async instead.

src/core/Akka.Streams.Tests/Dsl/UnfoldResourceSourceSpec.cs Outdated
p.Subscribe(c);
var sub = c.ExpectSubscription();

Enumerable.Range(0,50).ForEach(i =>
Enumerable.Range(0, 50).ForEach(i =>
{
sub.Request(1);
c.ExpectNext().Should().Be(i < 10 ? ManyLinesArray[i] : ManyLinesArray[i + 10]);
});
sub.Request(1);
c.ExpectComplete();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async instead

src/core/Akka.Streams.Tests/Dsl/UnfoldResourceSourceSpec.cs Outdated
@@ -147,14 +146,14 @@ public void A_UnfoldResourceSource_must_close_and_open_stream_again_when_strateg
c.ExpectNext().Should().Be(ManyLinesArray[0]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async instead

Aaronontheweb
Aaronontheweb approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 0b8cc60 into akkadotnet:dev Mar 30, 2023
@eaba eaba deleted the UnfoldResourceSourceSpec branch March 30, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaba @Aaronontheweb