Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[39-74] FlowWireTapSpec #6586

Merged
merged 6 commits into from
Apr 4, 2023
Merged

[39-74] FlowWireTapSpec #6586

merged 6 commits into from
Apr 4, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 25, 2023

Changes

  • Change AssertAllStagesStopped to AssertAllStagesStoppedAsync

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.RunWith(Sink.Ignore<int>(), Materializer).Wait();
foreach (var i in Enumerable.Range(1, 100))
await ExpectMsgAsync(i);
//Enumerable.Range(1, 100).Select(i => ExpectMsg(i));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented code

.RunWith(Sink.Ignore<string>(), Materializer)
.ContinueWith(_ => TestActor.Tell("done"));
await ExpectMsgAsync("done");
//return Task.CompletedTask;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented code

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) April 4, 2023 12:05
@Aaronontheweb Aaronontheweb disabled auto-merge April 4, 2023 18:38
@Aaronontheweb Aaronontheweb merged commit 2534f52 into akkadotnet:dev Apr 4, 2023
@eaba eaba deleted the FlowWireTapSpec branch April 4, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants