Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy Obsolete attributes to Akka.Persistence.TCK #6465

Merged
merged 4 commits into from
Feb 28, 2023
Merged

copy Obsolete attributes to Akka.Persistence.TCK #6465

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
207bed4
copy `Obsolete` attributes to Akka.Persistence.TCK
Aaronontheweb Feb 27, 2023
62e26fb
removed bad method
Aaronontheweb Feb 27, 2023
21522a2
Make sure that old Dispose method is called inside DisposeAsync
Arkatufus Feb 28, 2023
c1d9c2d
Remove Dispose, already implemented in TestKit
Arkatufus Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions src/core/Akka.Persistence.TCK/PluginSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//-----------------------------------------------------------------------

using System;
using System.Threading.Tasks;
using Akka.Actor;
using Akka.Actor.Setup;
using Akka.Configuration;
Expand Down Expand Up @@ -64,23 +65,6 @@ public void Subscribe<T>(IActorRef subscriber)
{
Sys.EventStream.Subscribe(subscriber, typeof (T));
}


public void Dispose()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add this back?

{
Dispose(true);
GC.SuppressFinalize(this);
}

/// <summary>Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources.</summary>
/// <param name="disposing">if set to <c>true</c> the method has been called directly or indirectly by a
/// user's code. Managed and unmanaged resources will be disposed.<br />
/// if set to <c>false</c> the method has been called by the runtime from inside the finalizer and only
/// unmanaged resources can be disposed.</param>
protected virtual void Dispose(bool disposing)
{
//if (disposing) FSMBase.Shutdown();
}
}
}