close #6295 - set default PoolRouter SupervisorStrategy to Restart #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also need to be ported to v1.5 @Arkatufus |
|
|
|
OK |
|
@Aaronontheweb fixed the unit test, can you check the code? |
Aaronontheweb
commented
Jan 26, 2023
|
|
||
| supervisor.Tell(new RoundRobinPool(3).Props(Props.Create(() => new RestartActor(TestActor)))); | ||
| var router = Sys.ActorOf(new RoundRobinGroup(routes.Select(a => a.Path.ToString())).Props()); |
There was a problem hiding this comment.
@Arkatufus this needs to be a RoundRobinPool router
Arkatufus
pushed a commit
to Arkatufus/akka.net
that referenced
this pull request
Jan 26, 2023
… Restart (akkadotnet#6366) * close akkadotnet#6295 - set default PoolRouter SupervisorStrategy to Restart * use the `SupervisionStrategy.DefaultStrategy` * Fix unit test * Change unit test to use RoundRobinPool router (cherry-picked from ffd9a9e)
Aaronontheweb
added a commit
that referenced
this pull request
Jan 30, 2023
) * close #6295 - set default PoolRouter SupervisorStrategy to Restart (#6366) * close #6295 - set default PoolRouter SupervisorStrategy to Restart * use the `SupervisionStrategy.DefaultStrategy` * Fix unit test * Change unit test to use RoundRobinPool router (cherry-picked from ffd9a9e) * Fix actor telemetry unit test --------- Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #6295 - this fixes a very old bug in Akka.NET where any time a routee on a
Poolrouter restarted, the default supervision directive on the router was set toEscalatewhich would cause the router itself to restart and kill all of the routees in the process. I believe this was done as a result of misunderstanding what Escalate does and how it works. We now know better and this sets the supervision directive toRestart, which is the safe default we use for everything else.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Directive.Escalateby default when supervising routees - this causes unintended consequences #6295