Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix unresolved base documentaion WARNINGS in Akka.DistributedData.PNCounter* #5632

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Docs: Fix unresolved base documentaion WARNINGS in Akka.DistributedData.PNCounter* #5632

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4580dad
Remove 'inheritdoc` from overriden members that can not be resolved b…
eaba Feb 10, 2022
47707ee
Merge branch 'dev' into fix_docfx_pn_counter
Aaronontheweb Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/contrib/cluster/Akka.DistributedData/PNCounter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public PNCounter Prune(Cluster.UniqueAddress removedNode, Cluster.UniqueAddress
public PNCounter PruningCleanup(Cluster.UniqueAddress removedNode) =>
new PNCounter(Increments.PruningCleanup(removedNode), Decrements.PruningCleanup(removedNode));

/// <inheritdoc/>

public bool Equals(PNCounter other)
{
if (ReferenceEquals(other, null)) return false;
Expand All @@ -109,13 +109,13 @@ public bool Equals(PNCounter other)
return other.Increments.Equals(Increments) && other.Decrements.Equals(Decrements);
}

/// <inheritdoc/>

public override string ToString() => $"PNCounter({Value})";

/// <inheritdoc/>

public override bool Equals(object obj) => obj is PNCounter && Equals((PNCounter)obj);

/// <inheritdoc/>

public override int GetHashCode() => Increments.GetHashCode() ^ Decrements.GetHashCode();

public IReplicatedData Merge(IReplicatedData other) => Merge((PNCounter)other);
Expand Down
10 changes: 5 additions & 5 deletions src/contrib/cluster/Akka.DistributedData/PNCounterDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public PNCounterDictionary<TKey> Prune(UniqueAddress removedNode, UniqueAddress
public PNCounterDictionary<TKey> PruningCleanup(UniqueAddress removedNode) =>
new PNCounterDictionary<TKey>(Underlying.PruningCleanup(removedNode));

/// <inheritdoc/>

public bool Equals(PNCounterDictionary<TKey> other)
{
if (ReferenceEquals(other, null)) return false;
Expand All @@ -188,19 +188,19 @@ public bool Equals(PNCounterDictionary<TKey> other)
return Equals(Underlying, other.Underlying);
}

/// <inheritdoc/>

public IEnumerator<KeyValuePair<TKey, BigInteger>> GetEnumerator() =>
Underlying.Select(x => new KeyValuePair<TKey, BigInteger>(x.Key, x.Value.Value)).GetEnumerator();
IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();

/// <inheritdoc/>

public override bool Equals(object obj) =>
obj is PNCounterDictionary<TKey> pairs && Equals(pairs);

/// <inheritdoc/>

public override int GetHashCode() => Underlying.GetHashCode();

/// <inheritdoc/>

public override string ToString()
{
var sb = new StringBuilder("PNCounterDictionary(");
Expand Down