-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec to check that Akka.Cluster.Metrics can be started automatically #5359
Add spec to check that Akka.Cluster.Metrics can be started automatically #5359
Conversation
/// </summary> | ||
private const int NodeCount = 1; | ||
private static readonly Config Config = ConfigurationFactory.ParseString(@" | ||
akka.extensions = [""Akka.Management.Cluster.Bootstrap.ClusterBootstrapProvider, Akka.Management.Cluster.Bootstrap""] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the wrong extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is, fixed it.
…ufus/akka.net into CLUSTER_METRICS_Add_autostart_spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once you make the markdown linter happy ;)
} | ||
} | ||
``` | ||
These settings will auto-start Akka.Cluster.Metrics using the default memory and CPU metrics collectors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
|
||
[Fact] | ||
public void Metrics_extension_Should_autostart_if_added_to_akka_extensions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.