Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported WireTap combinator #5357

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Ported WireTap combinator #5357

merged 3 commits into from
Nov 5, 2021

Conversation

ismaelhamed
Copy link
Member

This should also help with #4852

@ismaelhamed ismaelhamed force-pushed the wiretap-combinator branch 2 times, most recently from 2b5bf91 to 7c66035 Compare October 31, 2021 07:25
Aaronontheweb
Aaronontheweb reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - I'll clone the source and see what's up with that materializer call

src/core/Akka.API.Tests/CoreAPISpec.ApproveStreams.approved.txt
@@ -1406,6 +1406,9 @@ namespace Akka.Streams.Dsl
where TIn : TOut { }
public static Akka.Streams.Dsl.Flow<TIn, TOut, TMat> Where<TIn, TOut, TMat>(this Akka.Streams.Dsl.Flow<TIn, TOut, TMat> flow, System.Predicate<TOut> predicate) { }
public static Akka.Streams.Dsl.Flow<TIn, TOut, TMat> WhereNot<TIn, TOut, TMat>(this Akka.Streams.Dsl.Flow<TIn, TOut, TMat> flow, System.Predicate<TOut> predicate) { }
public static Akka.Streams.Dsl.Flow<TIn, TOut, TMat> WireTap<TIn, TOut, TMat>(this Akka.Streams.Dsl.Flow<TIn, TOut, TMat> flow, System.Action<TOut> action) { }
public static Akka.Streams.Dsl.Flow<TIn, TOut, TMat> WireTap<TIn, TOut, TMat>(this Akka.Streams.Dsl.Flow<TIn, TOut, TMat> flow, Akka.Streams.IGraph<Akka.Streams.SinkShape<TOut>, TMat> that) { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good

src/core/Akka.Streams/Dsl/Internal/InternalFlowOperations.cs Show resolved Hide resolved
@Aaronontheweb Aaronontheweb marked this pull request as ready for review November 5, 2021 18:51
Aaronontheweb
Aaronontheweb approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) November 5, 2021 18:53
@Aaronontheweb Aaronontheweb removed the request for review from Arkatufus November 5, 2021 18:54
@Aaronontheweb Aaronontheweb merged commit 28246c4 into akkadotnet:dev Nov 5, 2021
@Aaronontheweb Aaronontheweb mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-streams api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismaelhamed @Aaronontheweb