Make DisabledBufferPool as the default buffer pool implementation for UDP #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:Arkatufus/akka.net into #5325_Make_DisabledBufferPool_as_UDP_default
Aaronontheweb
requested changes
Oct 19, 2021
| @@ -3889,14 +3889,12 @@ namespace Akka.IO | |||
| } | |||
| public class UdpSettings | |||
| { | |||
| public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int directBufferSize, int maxDirectBufferPoolSize, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher) { } | |||
There was a problem hiding this comment.
Ah, that's a breaking change - should probably leave the C# settings all there and just change the defaults to use the disabled buffer pool. No need to remove the feature entirely - we just don't want it as the default until it's fixed.
There was a problem hiding this comment.
its byterot, i'm not removing it
There was a problem hiding this comment.
Brought back the old constructor, marking it as obsolete
Aaronontheweb
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5325 - patches issue by disabling it.