Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed GetChild benchmark #5243

Merged
merged 1 commit into from
Sep 2, 2021
Merged

fixed GetChild benchmark #5243

merged 1 commit into from
Sep 2, 2021

Conversation

Aaronontheweb
Copy link
Member

turns out my original benchmark was wrong - as it ran headfirst into a bad resolve for GetChild.

This benchmark results in a good resolve.

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) September 2, 2021 02:43
@Aaronontheweb
Copy link
Member Author

New numbers

BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19041.1165 (2004/May2020Update/20H1)
AMD Ryzen 7 1700, 1 CPU, 16 logical and 8 physical cores
.NET SDK=5.0.302
  [Host]     : .NET Core 3.1.17 (CoreCLR 4.700.21.31506, CoreFX 4.700.21.31502), X64 RyuJIT
  DefaultJob : .NET Core 3.1.17 (CoreCLR 4.700.21.31506, CoreFX 4.700.21.31502), X64 RyuJIT
Method Mean Error StdDev Gen 0 Allocated
ResolveChild 67.12 ns 0.041 ns 0.035 ns - -
Resolve3DeepChildRepointableActorRef 534.29 ns 2.166 ns 1.809 ns 0.0324 136 B
Resolve3DeepChildLocalActorRef 367.67 ns 0.650 ns 0.543 ns 0.0095 40 B

@Aaronontheweb Aaronontheweb merged commit 77ed55d into akkadotnet:dev Sep 2, 2021
@Aaronontheweb Aaronontheweb mentioned this pull request Sep 2, 2021
Merged
@Aaronontheweb Aaronontheweb deleted the fix/GetChild-benchmark branch September 2, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
akka-actor perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Aaronontheweb