Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singleton fix cleanup of overdue _removed members #5229

Merged
merged 2 commits into from
Aug 30, 2021
Merged

singleton fix cleanup of overdue _removed members #5229

merged 2 commits into from
Aug 30, 2021

Conversation

zbynek001
Copy link
Contributor

current logic seems reverted

Aaronontheweb
Aaronontheweb approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - definitely looks like a bug

@Aaronontheweb Aaronontheweb removed the request for review from Arkatufus August 30, 2021 14:22
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) August 30, 2021 14:22
@Aaronontheweb Aaronontheweb added this to the 1.4.25 milestone Aug 30, 2021
@Aaronontheweb Aaronontheweb disabled auto-merge August 30, 2021 15:50
@Aaronontheweb Aaronontheweb merged commit 3df4b90 into akkadotnet:dev Aug 30, 2021
This was referenced Sep 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-cluster-tools confirmed bug
Projects
None yet
Milestone
1.4.25
Development

Successfully merging this pull request may close these issues.
2 participants
@zbynek001 @Aaronontheweb