fix cluster startup race

[Zetanova]

There is a race condition in ClusterDomainEventPublisher and ClusterCoreDaemon both used Cluster.Get(system) to get the cluster instance. If the ActorCells are activated before the Cluster constructer gets the answer in _clusterCore = GetClusterCoreRef().Result it will crash.

close #5184

[Aaronontheweb]

This definitely introduced some bugs - we might not be able to safely do this. The the blocking wait in the constructor was intentional.

[Aaronontheweb]

This definitely introduced some bugs - we might not be able to safely do this. The the blocking wait in the constructor was intentional.

Not to say that it's impossible to fix, but it may not be so straightforward

[Zetanova]

I didn't remove the lock.

The PR passes the Cluster instance to the ClusterCoreDaemon directly
To remove Cluster.Get(system) from the constructor.

[Zetanova]

I only tested it with RemotePingPong and it worked.

[Aaronontheweb]

I didn't remove the lock.

The PR passes the Cluster instance to the ClusterCoreDaemon directly
To remove Cluster.Get(system) from the constructor.

Got it - I misunderstood. I'll take a closer look at this today.

[to11mtm]

@Zetanova I think you need to fix this line in ClusterDomainEventPublisherSpec.cs to get tests to pass:

//in public ClusterDomainEventPublisherSpec() : base(Config)
_publisher = Sys.ActorOf(Props.Create<ClusterDomainEventPublisher>()); //~line 66

Props.Create without a functor tries to look for a default constructor; due to your changes there is none here.

[Zetanova]

@to11mtm thx

Why DDataStressTest.csproj failed to build at .net core unit test (linux) ?

[to11mtm]

@to11mtm thx

Happy to help!

Why DDataStressTest.csproj failed to build at .net core unit test (linux) ?

Not entirely sure on that one, although I know that @Aaronontheweb has been working through some challenges on LMDB native dlls, might be related so tagging him.

[Aaronontheweb]

@Zetanova the DDataStressTest is a project we can possibly remove - we used it to help reproduce some data stemming from #5022

[Aaronontheweb]

LGTM

[Aaronontheweb]

Good call