Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IActorRef Equals and CompareTo behavior change #4324

Merged
merged 1 commit into from
Mar 13, 2020
Merged

IActorRef Equals and CompareTo behavior change #4324

merged 1 commit into from
Mar 13, 2020

Conversation

Arkatufus
Copy link
Contributor

Closes #3781

Aaronontheweb
Aaronontheweb approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change, but I think it should be alright.

src/core/Akka/Actor/ActorRef.cs
var other = obj as IActorRef;
if (other == null) return false;
return Equals(other);
if (obj is IActorRef other)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka/Actor/ActorRef.cs
public bool Equals(IActorRef other)
{
if (other is null) return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 82e9759 into akkadotnet:dev Mar 13, 2020
@Arkatufus Arkatufus deleted the #3781_IActorRef_Equals_and_CompareTo_behavior branch February 27, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActorRefBase.Equals(IActorRef) and ActorRefBase.CompareTo(IActorRef) do not handle null parameters properly
2 participants
@Arkatufus @Aaronontheweb