harden DData.Tests.WriteAggregatorSpecs #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Feb 27, 2020
| @@ -162,9 +162,14 @@ public void WriteAggregator_must_timeout_when_less_than_required_ACKs() | |||
| // no reply | |||
| probe.ExpectMsg<Write>(); | |||
| // no reply | |||
| ExpectMsg(new UpdateTimeout(KeyA, null)); | |||
There was a problem hiding this comment.
We've set the WriteTimeout in all of the various write consistencies used in this spec to at least 3 seconds depending on the consistency level used and the dilation factor, without updating any of the assertions - which wait at most 3 seconds. Thus we can prematurely blow up the spec before the WriteAggregator has had a chance to actually generate its timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #3786