Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix racy test: Akka.Tests.IO.TcpIntegrationSpec.Should_fail_writing_when_buffer_is_filled #4160

Merged

Conversation

IgorFedchenko
Copy link
Contributor

Related to #3786

Fix racy test: Akka.Tests.IO.TcpIntegrationSpec.Should_fail_writing_when_buffer_is_filled

Test is pretty straightforward, and failes on sending data to TcpConnection actor and waiting for response. Maybe related to the fact that it is sending 2 messages by 10Kb each.

Anyway, lets try to increase timeouts, and use AwaitAssertAsync to make several tries with pauses

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit f783b82 into akkadotnet:dev Jan 23, 2020
@IgorFedchenko IgorFedchenko deleted the fix/racy-filled-buffer-test branch January 24, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants