Fix racy test: Akka.Cluster.Sharding.Tests.CoordinatedShutdownShardingSpec.Sharding_and_CoordinatedShutdown_must_run_successfully #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we need to run this 10-20 times to make sure it is not failing anymore, since it is passing in 87% cases (according to this report |
|
Mm, also most likely we need to start all the Akka tests to make CI loaded... So will add some spaces to the core project. |
Aaronontheweb
approved these changes
Jan 23, 2020
| { | ||
| _region2.Tell(1, _probe2.Ref); | ||
| _probe2.ExpectMsg<int>(1.Seconds()).Should().Be(1); |
There was a problem hiding this comment.
I'd leave these at 1 second each, but just expand the total wait time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3786
This PR should improve/fix flip rate of this test: Akka.Cluster.Sharding.Tests.CoordinatedShutdownShardingSpec.Sharding_and_CoordinatedShutdown_must_run_successfully
It is time sensitive and failing due to timeouts (because of remote address gating). Seems like the test is correct by itself, so lets start with using
asynctest APIs and increasing timeouts.