[SpecFix] working on fixing AtLeastOnceDeliveryCrashSpec #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igured_with_a_failing_directory
Aaronontheweb
commented
May 23, 2019
| Task.Run(() => | ||
| { | ||
| Thread.Sleep(10); | ||
| return msg; | ||
| }).PipeTo(Sender, Self); //LogicalContext is lost?!? | ||
| }).PipeTo(sender, self); |
There was a problem hiding this comment.
Fixed this spec too - would sometimes fail because we didn't close over Sender .
There was a problem hiding this comment.
This isn't the final fix here - still having issues.
|
Still having issues with |
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
…3806) * akkadotnet#3786 - working on fixing AtLeastOnceDeliveryCrashSpec * fixed issue with SnapshotDirectoryFailureSpec.LocalSnapshotStore_configured_with_a_failing_directory * fixed Akka.Persistence.Tests.Actor_PipeTo_should_not_be_delayed_by_async_receive * looks like issue might be related to parallel execution and thread blocking * added logging for AtLeastOnceDelivery_must_tolerate_and_recover_from_random_failures
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 30, 2019
…3806) * akkadotnet#3786 - working on fixing AtLeastOnceDeliveryCrashSpec * fixed issue with SnapshotDirectoryFailureSpec.LocalSnapshotStore_configured_with_a_failing_directory * fixed Akka.Persistence.Tests.Actor_PipeTo_should_not_be_delayed_by_async_receive * looks like issue might be related to parallel execution and thread blocking * added logging for AtLeastOnceDelivery_must_tolerate_and_recover_from_random_failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3786 - added some debug logging to see why this test is racy. Looks like it's either an issue with Recovery, the timing configuration of the
AtLeastOnceDeliveryActorin this spec, or theAtLeastOnceDeliverySemanticnot handling recoveries properly.