Timers for self scheduled messages added, FSM timers fixes #3778
Conversation
|
@zbynek001 Nice!! I ported just the fix a while back (#3313) but the rest of that PR has been in my backlog since then. |
|
@zbynek001 @Aaronontheweb any news on this one? |
There was a problem hiding this comment.
Need some API changes
We also need to add some docs to describe how to send recurring messages using this interface here:
https://github.com/akkadotnet/akka.net/tree/dev/docs/articles/actors
I'd recommend adding a new article called "recurring and timed messages"
|
@zbynek001 updated the review - I think this needs some minor API changes and some documentation, but otherwise looks like a great improvement. |
|
@Aaronontheweb Should it be done via the Actor producer pipeline or directly in |
|
@zbynek001 I was going to suggest that, but ultimately deleted it. I think that's probably a better way to go though - have it be done via the way actors are created. I think that'd be a good compromise for now. We're going to have to replace that pipeline with something else eventually and I get the feeling that default interfaces probably aren't going to be it. |
|
at the end had to initialize Timers in |
|
this should be ready. I guess the failed test is unrelated to this pr and at least locally it's all passing |
| @@ -105,6 +103,10 @@ protected ActorBase() | |||
| { | |||
| if (ActorCell.Current == null) | |||
| throw new ActorInitializationException("Do not create actors using 'new', always create them using an ActorContext/System"); | |||
|
|
|||
| if (this is IWithTimers withTimers) | |||
src/core/Akka/Actor/ActorBase.cs
Outdated
| @@ -92,7 +91,6 @@ public interface IInternalActor | |||
| public abstract partial class ActorBase : IInternalActor | |||
| { | |||
| private IActorRef _clearedSelf; | |||
| private Scheduler.TimerScheduler timers; | |||
|
We're going to need to document these changes - for the time being I've created an open issue here: #4357 |
migrated from akka/akka#22873