Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warning for serializer configuration changes #6377

Closed
beachwalker opened this issue Jan 31, 2023 · 0 comments · Fixed by #6378
Closed

Suppress warning for serializer configuration changes #6377

beachwalker opened this issue Jan 31, 2023 · 0 comments · Fixed by #6378

Comments

@beachwalker
Copy link
Contributor

Problem description
If the serializers default configuration is changed then a WARNING is written into the log to make sure if this is really meant to be changed. However if the change was indeed the intend, there is no possibility to switch off further notifications about this "problem" to keep focus on other possible unintended issues.

Possible solution
The desired solution would be to add a switch to disable this behavior. The default should be "on" (logging the possible issue at first sight).

Considered alternatives
The alternative of increasing the log level is not a reasonable solution (although you get rid of the serializer change messages) because this also hides notifications about other (unitended) issues, too.
I was not able to disable logging (through logger config) only for this class, but even if it would have worked... are there any other important notifications that could possibly swallowed without intention?

Additional context
The log messages to be suppressed are located within the Serialization class at

public void AddSerializer(Serializer serializer)
.

@beachwalker beachwalker mentioned this issue Jan 31, 2023
6 tasks
@Aaronontheweb Aaronontheweb added this to the 1.4.50 milestone Feb 1, 2023
Aaronontheweb added a commit that referenced this issue Feb 7, 2023
* Fix for issue #6377

* created a setting property LogSerializerOverrideOnStart to reflect if warning should be logged or not
* updated default config to enable logging for this issue by default
* added property to the configuration Spezifikation

* added API approvals

---------

Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants