Fix preserved reference surrogate in collection deserialization bug #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problem was caused by wrongly stored reference in DeserializeSession: #263 (comment) |
Arkatufus
commented
Oct 7, 2021
| @@ -65,6 +65,15 @@ public object GetDeserializedObject(int id) | |||
| return _objectById[id]; | |||
| } | |||
|
|
|||
| public void ReplaceOrAddTrackedDeserializedObject([NotNull] object origin, [NotNull] object replacement) | |||
There was a problem hiding this comment.
This method will search the current reference array for surrogated object instance and replace it with the actual object reference value
Arkatufus
commented
Oct 7, 2021
| @@ -37,6 +42,8 @@ public override object ReadValue(Stream stream, DeserializerSession session) | |||
| { | |||
| var surrogateValue = _surrogateSerializer.ReadValue(stream, session); | |||
| var value = _translator(surrogateValue); | |||
| if(_preserveObjectReferences) | |||
| session.ReplaceOrAddTrackedDeserializedObject(surrogateValue, value); | |||
There was a problem hiding this comment.
Replace the wrongly injected surrogate object with the actual deserialized de-surrogated value.
Value might be wrongly stored by _surrogateSerializer.ReadValue() in line 43.
There was a problem hiding this comment.
Boy this must have been a fun one to track down.
Aaronontheweb
approved these changes
Oct 7, 2021
| @@ -37,6 +42,8 @@ public override object ReadValue(Stream stream, DeserializerSession session) | |||
| { | |||
| var surrogateValue = _surrogateSerializer.ReadValue(stream, session); | |||
| var value = _translator(surrogateValue); | |||
| if(_preserveObjectReferences) | |||
| session.ReplaceOrAddTrackedDeserializedObject(surrogateValue, value); | |||
There was a problem hiding this comment.
Boy this must have been a fun one to track down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263