Add exception handling for exception logging #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| catch (Exception e) | ||
| { | ||
| throw new Exception( |
There was a problem hiding this comment.
Should this be a SerializationException or something more specific? Do we have any Hyperion-specific exception types?
There was a problem hiding this comment.
SerializationException doesn't exist in netstandard1.6 and net45
There was a problem hiding this comment.
I guess we can add System.Runtime.Serialization.Primitives package to add it in?
|
Let's push out a new release with these changes included so we can try to track down akkadotnet/akka.net#5102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.