WIP Communicate between framework mscorlib and core framework System.Private.CoreLib #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to get a unit test for this... Don't have a clear idea for how to do that off the top of my head |
|
We could commit serialized files in both framework, unit test will pass if they can deserialize both of them from the 2 frameworks. We create explicit tests to create those files so if something else changes and break those tests, it's easy to commit new versions. What do you think ? |
|
@nekenk1 yeah, I'd just save a file - one written by .NET framework, one by core, and have the opposites read each other back into the original result. That would work. |
Aaronontheweb
pushed a commit
that referenced
this pull request
Oct 15, 2019
…it Tests (#116) * Communicate between mscorlib and System.Private.CoreLib * Strict string match * Add a binary file generator for all .NET frameworks * Add generated serialized files to project as suggestted in #112 (comment) * Add unit tests to test cross framework serialization and deserialization * FullFramework or CoreNetFramework runtime check * Using Constants instead * Downgrade FSharp.Core 4.7.0 to 4.6.2 because 4.7.0 is not compatible with netstandard1.6 * Add generated serialized file for .NET Core 3.0 to project * Add netcoreapp2.2 support to Hyperion.Tests Update Windows vm image to windows-2019 * Remove netcoreapp2.2 from Hyperion.Tests
|
closed via #116 |
Aaronontheweb
added a commit
that referenced
this pull request
Jan 20, 2020
* Support ArrayList * Remove wrong copyright * Communicate between mscorlib and System.Private.CoreLib * Strict string match * Add a binary file generator for all .NET frameworks * Add generated serialized files to project as suggestted in #112 (comment) * Add unit tests to test cross framework serialization and deserialization * Readd new line * added comment to explain null-coalescing operation Co-authored-by: alexvaut <alex@vautier.biz> Co-authored-by: humhei <humhei@outlook.com> Co-authored-by: Deniz İrgin <denizirgin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #108
Not very sure,
But it worked for me now,
Wait others to confirm