Bump Akka.TestKit from 1.5.33 to 1.5.34

[milang]

Changes

Bumps Akka.TestKit from 1.5.33 to 1.5.34.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

• I have reviewed my own pull request.

[milang]

@Aaronontheweb update Akka.TestKit.NUnit to the latest Akka.NET that was released today.

[milang]

@Aaronontheweb could you please publish the new build to NuGet?

[Aaronontheweb]

Sure thing, I'll see about doing that - btw, do you think this issue is related to the one you fixed? akkadotnet/akka.net#7442

It's an issue with the main Akka.NET TestKit, so not specific to NUnit.

[milang]

@Aaronontheweb

Thank you for the publish.

Do you think this issue is related to the one you fixed?

I don't think so, the reproduction repository is using XUnit -- unless a similar technique is used in Akka.TestKit.XUnit to build the assertion message, passing the message + arguments directly to string.Format.

[milang]

@Aaronontheweb

Do you think this issue is related to the one you fixed?

Actually you are correct, it is the same reason as the NUnit failure. Current Akka.TestKit.Xunit2 implementation just forwards the message and arguments directly to string.Format:
https://github.com/akkadotnet/akka.net/blob/dev/src/contrib/testkits/Akka.TestKit.Xunit2/XunitAssertions.cs#L37

The fix should be the same as #159, return the message as-is if no formatting arguments were specified. If Xunit doesn't have a helper method like NUnit, you can implement your own:

private static string BuildAssertMessage(string? format, object?[]? args)
{
    return string.IsNullOrEmpty(format)
        ? string.Empty
        : args is { Length: > 0 } // C# pattern matching, not available in older compilers
            ? string.Format(format, args)
            : format;
}