Event envelope updates #170
Conversation
…h missing Tests not in the latest version of 1.4.11
…n_the_last_subscriber_left()
* Add FluentAssertionsVersion to Common.Props and set the version to 4.14.0 * Fix failing persistence tests
|
Once this is merged, I will need to refork to have a clean commit history for each new branch. |
| [BsonElement("Ordering")] | ||
| public BsonTimestamp Ordering { get; set; } | ||
|
|
||
| [BsonElement("Timestamp")] | ||
| public BsonTimestamp Timestamp { get; set; } |
There was a problem hiding this comment.
We should just use the Ordering field instead - we can't back-date the previous journal entries otherwise this will cause total chaos.
| @@ -319,7 +321,7 @@ private JournalEntry ToJournalEntry(IPersistentRepresentation message) | |||
| Id = message.PersistenceId + "_" + message.SequenceNr, | |||
| //Ordering = _sequenceRepository.GetSequenceValue("journalentry"), | |||
| Ordering = new BsonTimestamp(0), // Auto-populates with timestamp | |||
| //Timestamp = new BsonTimestamp(0), | |||
| Timestamp = new BsonTimestamp(timeStamp), | |||
| @@ -398,12 +402,12 @@ private Persistent ToPersistenceRepresentation(JournalEntry entry, IActorRef sen | |||
| if (deserialized is Persistent p) | |||
| return p; | |||
|
|
|||
| return new Persistent(deserialized, entry.SequenceNr, entry.PersistenceId, entry.Manifest, entry.IsDeleted, sender); | |||
| return new Persistent(deserialized, entry.SequenceNr, entry.PersistenceId, entry.Manifest, entry.IsDeleted, sender, timestamp: entry.Timestamp.Timestamp); | |||
| object payload = message.Payload; | ||
| message = message.WithTimestamp(timeStamp); |
There was a problem hiding this comment.
You can get rid of this call - it's not needed. We already have the equivalent of this with the Ordering field - just that in that instance the clock time is set by MongoDb
| @@ -11,6 +11,7 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Akka.Persistence.Query" Version="$(AkkaVersion)" /> | |||
| <PackageReference Include="akka.streams" Version="$(AkkaVersion)" /> | |||
| <PackageReference Include="MongoDB.Driver" Version="2.11.4" /> | |||
There was a problem hiding this comment.
Why? We already have a reference to MongoDb.Driver on the line below
There was a problem hiding this comment.
Did not know how that happened.....I will take care of it.
| @@ -398,12 +403,12 @@ private Persistent ToPersistenceRepresentation(JournalEntry entry, IActorRef sen | |||
| if (deserialized is Persistent p) | |||
| return p; | |||
There was a problem hiding this comment.
need to add WithTimestamp here
No description provided.